[do not merge] make server and client private to reduce public api surface and clean up typing #44109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0lawrence
commented
Nov 19, 2025
| azure.ai.agentserver.core.server.common.id\_generator package | ||
| ============================================================= | ||
|
|
||
| .. automodule:: azure.ai.agentserver.core.server.common.id_generator |
Member
Author
There was a problem hiding this comment.
unsure if these are needed if server is internal
l0lawrence
changed the title
l0lawrence
commented
Nov 19, 2025
| from azure.ai.agentserver.core.logger import get_logger | ||
| if TYPE_CHECKING: | ||
| from azure.ai.agentserver.core.client.tools.aio import AzureAIToolClient, FoundryTool | ||
| from azure.ai.agentserver.core import AzureAIToolClient, FoundryTool |
Member
Author
There was a problem hiding this comment.
Suggested change
| from azure.ai.agentserver.core import AzureAIToolClient, FoundryTool | |
| from azure.ai.agentserver.core.aio import AzureAIToolClient, FoundryTool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on 1.0.0b1 not most recent beta changes -- missing client async and sync AzureAIToolClient